jenkins-bot has submitted this change and it was merged.
Change subject: Avoid doing "new $className()" in ChangeRunCoalescerTest
......................................................................
Avoid doing "new $className()" in ChangeRunCoalescerTest
Change-Id: I971569163a33aecc7706892a1e496cb6c202ba85
---
M client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
b/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
index 1147d16..13ffa83 100644
--- a/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
+++ b/client/tests/phpunit/includes/Changes/ChangeRunCoalescerTest.php
@@ -123,12 +123,12 @@
$diff = $this->makeDiff( $values['object_id'],
$values['info']['metadata']['parent_id'], $values[ 'revision_id' ] );
$values['info'] = serialize( $values['info'] );
- $class = EntityChange::class;
if ( $values['type'] === 'wikibase-item~add' || $values['type']
=== 'wikibase-item~update' ) {
- $class = ItemChange::class;
+ $change = new ItemChange( $values );
+ } else {
+ $change = new EntityChange( $values );
}
- $change = new $class( $values );
$change->setDiff( $diff );
return $change;
--
To view, visit https://gerrit.wikimedia.org/r/277998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I971569163a33aecc7706892a1e496cb6c202ba85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
