Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/278240

Change subject: Slightly faster inputextender's expand animation
......................................................................

Slightly faster inputextender's expand animation

Note that there are two phases of animation: First, the expert fades
in (opacity is animated from 0 to 1). This happens very fast, 150ms.
When this is done, the stuff below the expert moves down. This happens
with the default "fast" animation speed (200ms by default).

I was under the impression that fixed numbers can not be turned off,
but this was wrong. $.fx.off=true turns them all off, at least in this
case where it's a jQuery controlled animation.

Bug: T103834
Change-Id: I8657e178d2a0b355eabc504f95a1ab883644d3c4
---
M lib/jquery.ui/jquery.ui.inputextender.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/data-values/value-view 
refs/changes/40/278240/1

diff --git a/lib/jquery.ui/jquery.ui.inputextender.js 
b/lib/jquery.ui/jquery.ui.inputextender.js
index 6629b7e..47e0c1b 100644
--- a/lib/jquery.ui/jquery.ui.inputextender.js
+++ b/lib/jquery.ui/jquery.ui.inputextender.js
@@ -394,7 +394,7 @@
                        'extensionexpansion',
                        'fadeIn',
                        {
-                               duration: 150, // TODO: Fixed values can't be 
changed nor turned off
+                               duration: 100,
                                complete: function() {
                                        if ( $.isFunction( callback ) ) {
                                                callback();
@@ -421,7 +421,7 @@
                        'extensionremoval',
                        'fadeOut',
                        {
-                               duration: 150, // TODO: Fixed values can't be 
changed nor turned off
+                               duration: 100,
                                complete: function() {
                                        
inputExtendersWithVisibleExtension.remove( self );
                                        if ( $.isFunction( callback ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/278240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8657e178d2a0b355eabc504f95a1ab883644d3c4
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to