jenkins-bot has submitted this change and it was merged.
Change subject: ce.Surface: Add tests for table strip delete
......................................................................
ce.Surface: Add tests for table strip delete
Change-Id: I566b30613bf5c282dfb0265f3014f5c3d550d11d
---
M tests/ce/ve.ce.Surface.test.js
1 file changed, 29 insertions(+), 8 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js
index c432223..c09dda2 100644
--- a/tests/ce/ve.ce.Surface.test.js
+++ b/tests/ce/ve.ce.Surface.test.js
@@ -53,7 +53,7 @@
view.destroy();
};
-QUnit.test( 'handleLinearDelete', function ( assert ) {
+QUnit.test( 'special key down: backspace/delete', function ( assert ) {
var i,
emptyList = '<ul><li><p></p></li></ul>',
cases = [
@@ -359,6 +359,32 @@
},
expectedRangeOrSelection: new ve.Range( 1 ),
msg: 'Backspace with an alien selected deletes
it and replaces it with a paragraph, when the alien is the entire document'
+ },
+ {
+ rangeOrSelection: {
+ type: 'table',
+ tableRange: new ve.Range( 5, 37 ),
+ fromCol: 0,
+ fromRow: 0,
+ toCol: 0,
+ toRow: 0
+ },
+ operations: [ 'backspace' ],
+ expectedData: function ( data ) {
+ data.splice( 9, 24,
+ { type: 'paragraph', internal:
{ generated: 'wrapper' } },
+ { type: '/paragraph' }
+ );
+ },
+ expectedRangeOrSelection: {
+ type: 'table',
+ tableRange: new ve.Range( 5, 15 ),
+ fromCol: 0,
+ fromRow: 0,
+ toCol: 0,
+ toRow: 0
+ },
+ msg: 'Table cell emptied by backspace'
}
];
@@ -372,7 +398,7 @@
}
} );
-QUnit.test( 'handleLinearEnter', function ( assert ) {
+QUnit.test( 'special key down: linear enter', function ( assert ) {
var i,
emptyList = '<ul><li><p></p></li></ul>',
cases = [
@@ -2172,7 +2198,7 @@
} );
-QUnit.test( 'handleTableArrowKey', function ( assert ) {
+QUnit.test( 'special key down: table arrow keys', function ( assert ) {
var i, offsets, selection, table, view, model,
fn = function () {},
tables = {
@@ -2522,11 +2548,6 @@
// TODO: ve.ce.Surface#startRelocation
// TODO: ve.ce.Surface#endRelocation
// TODO: ve.ce.Surface#handleInsertion
-// TODO: ve.ce.Surface#handleLinearLeftOrRightArrowKey
-// TODO: ve.ce.Surface#handleLinearUpOrDownArrowKey
-// TODO: ve.ce.Surface#handleTableDelete
-// TODO: ve.ce.Surface#handleTableEditingEscape
-// TODO: ve.ce.Surface#handleTableEnter
// TODO: ve.ce.Surface#showModelSelection
// TODO: ve.ce.Surface#appendHighlights
// TODO: ve.ce.Surface#incRenderLock
--
To view, visit https://gerrit.wikimedia.org/r/278308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I566b30613bf5c282dfb0265f3014f5c3d550d11d
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
