Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278084
Change subject: Don't add two headers for talk section overlay
......................................................................
Don't add two headers for talk section overlay
talkSection.hogan is not an overlay template but a template partial
for the content field.
The header is defined in talkSectionHeader
Rename the file to avoid future confusion.
Bug: T126792
Change-Id: I6688b8b2f0833a54403bcb5142fb48a101867b15
---
M extension.json
R resources/mobile.talk.overlays/talkSectionContent.hogan
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/84/278084/1
diff --git a/extension.json b/extension.json
index 7fa686d..ad673d6 100644
--- a/extension.json
+++ b/extension.json
@@ -848,7 +848,7 @@
"SectionAddOverlay/contentHeader.hogan":
"resources/mobile.talk.overlays/talkSectionAddContentHeader.hogan",
"SectionAddOverlay.hogan":
"resources/mobile.talk.overlays/talkSectionAdd.hogan",
"Section/header.hogan":
"resources/mobile.talk.overlays/talkSectionHeader.hogan",
- "Section/content.hogan":
"resources/mobile.talk.overlays/talkSection.hogan"
+ "Section/content.hogan":
"resources/mobile.talk.overlays/talkSectionContent.hogan"
},
"messages": [
"mobile-frontend-talk-overlay-header",
diff --git a/resources/mobile.talk.overlays/talkSection.hogan
b/resources/mobile.talk.overlays/talkSectionContent.hogan
similarity index 82%
rename from resources/mobile.talk.overlays/talkSection.hogan
rename to resources/mobile.talk.overlays/talkSectionContent.hogan
index b1a62fd..282f5e2 100644
--- a/resources/mobile.talk.overlays/talkSection.hogan
+++ b/resources/mobile.talk.overlays/talkSectionContent.hogan
@@ -1,7 +1,3 @@
-<div class="overlay-header-container position-fixed">
- {{>header}}
-</div>
-
<div class="content talk-section">
{{{section.text}}}
{{{spinner}}}
--
To view, visit https://gerrit.wikimedia.org/r/278084
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6688b8b2f0833a54403bcb5142fb48a101867b15
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
