jenkins-bot has submitted this change and it was merged.
Change subject: PHP is not JavaScript
......................................................................
PHP is not JavaScript
(thankfully)
Note 0 || 5 equates to true not 5.
Bug: T130155
Change-Id: I68e80a431a45d4cd0935b010dcec1c093397b1ad
---
M includes/api/ApiMobileView.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiMobileView.php b/includes/api/ApiMobileView.php
index 61c2d64..3231ea3 100644
--- a/includes/api/ApiMobileView.php
+++ b/includes/api/ApiMobileView.php
@@ -485,8 +485,7 @@
$latest = $wp->getLatest();
// Use page_touched so template updates invalidate cache
$touched = $wp->getTouched();
-
- $revId = $oldid || $title->getLatestRevID();
+ $revId = $oldid ? $oldid : $title->getLatestRevID();
if ( $this->file ) {
$key = wfMemcKey( 'mf', 'mobileview',
self::CACHE_VERSION, $noImages,
$touched, $this->noTransform,
$this->file->getSha1(), $this->variant );
--
To view, visit https://gerrit.wikimedia.org/r/277891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68e80a431a45d4cd0935b010dcec1c093397b1ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.27.0-wmf.17
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
