Madhuvishy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278337
Change subject: Upgrade to latest UA-Parser version
......................................................................
Upgrade to latest UA-Parser version
This patch upgrades refinery source to use the latest version of
UA-Parser (1.3.0-wmf3) - this update includes some upgrades to uap-core
yaml definitions and bug fixes to uap-java. Tests that break in refinery-
source due to the upgrade are also fixed - the breaking tests were due
to the new ua-parser differentiating between Mobile Safari in iOS and
Mobile Safari UIWebview in iOS apps.
Bug: T130399
Change-Id: I83d2686037b7db9d2ba2130cb7468a7c3c8e40e8
---
M pom.xml
M
refinery-core/src/test/java/org/wikimedia/analytics/refinery/core/TestUAParserUserAgentRecognition.java
M
refinery-hive/src/test/java/org/wikimedia/analytics/refinery/hive/TestUAParserUDFUserAgentRecognition.java
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery/source
refs/changes/37/278337/1
diff --git a/pom.xml b/pom.xml
index 296bfa6..f4f73f9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -133,7 +133,7 @@
<dependency>
<groupId>ua_parser</groupId>
<artifactId>ua-parser</artifactId>
- <version>1.3.0-wmf2</version>
+ <version>1.3.0-wmf3</version>
</dependency>
<dependency>
diff --git
a/refinery-core/src/test/java/org/wikimedia/analytics/refinery/core/TestUAParserUserAgentRecognition.java
b/refinery-core/src/test/java/org/wikimedia/analytics/refinery/core/TestUAParserUserAgentRecognition.java
index 9dd76dc..5dbfeb8 100644
---
a/refinery-core/src/test/java/org/wikimedia/analytics/refinery/core/TestUAParserUserAgentRecognition.java
+++
b/refinery-core/src/test/java/org/wikimedia/analytics/refinery/core/TestUAParserUserAgentRecognition.java
@@ -55,7 +55,7 @@
assertEquals("OS name check", (new String("iOS")),
evaled.get("os_family").toString());
- assertEquals("Browser name check", (new String("Mobile Safari")),
+ assertEquals("Browser name check", (new String("Mobile Safari
UIWebView")),
evaled.get("browser_family").toString());
diff --git
a/refinery-hive/src/test/java/org/wikimedia/analytics/refinery/hive/TestUAParserUDFUserAgentRecognition.java
b/refinery-hive/src/test/java/org/wikimedia/analytics/refinery/hive/TestUAParserUDFUserAgentRecognition.java
index 76a387c..7947096 100644
---
a/refinery-hive/src/test/java/org/wikimedia/analytics/refinery/hive/TestUAParserUDFUserAgentRecognition.java
+++
b/refinery-hive/src/test/java/org/wikimedia/analytics/refinery/hive/TestUAParserUDFUserAgentRecognition.java
@@ -65,7 +65,7 @@
assertEquals("OS name check", (new String("iOS")),
evaled.get("os_family").toString());
- assertEquals("Browser name check", (new String("Mobile Safari")),
+ assertEquals("Browser name check", (new String("Mobile Safari
UIWebView")),
evaled.get("browser_family").toString());
--
To view, visit https://gerrit.wikimedia.org/r/278337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83d2686037b7db9d2ba2130cb7468a7c3c8e40e8
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery/source
Gerrit-Branch: master
Gerrit-Owner: Madhuvishy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
