TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/278573
Change subject: Allow audio player to be larger than 220px
......................................................................
Allow audio player to be larger than 220px
This is a stupid mistake that normalized the audio player to use a
default of 220px as a 'natural' width and then restricted the
thumbnailing to be no larger than the 'natural' size. As such audio
players were never allowed to be larger than 220px.
Audio players under 220px in many conditions will not have a seekbar,
since there is not enough room on the controller to present this
seekbar.
Bug: T56370
Change-Id: I6362076e8a24234d2350bc6eb54c81fa9fef04cc
---
M TimedMediaHandler_body.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/73/278573/1
diff --git a/TimedMediaHandler_body.php b/TimedMediaHandler_body.php
index e5d0c70..530848c 100644
--- a/TimedMediaHandler_body.php
+++ b/TimedMediaHandler_body.php
@@ -159,7 +159,7 @@
);
}
// Make sure we don't try and up-scale the asset:
- if ( isset( $params['width'] ) && (int)$params['width'] >
$size['width'] ) {
+ if ( !$this->isAudio( $image ) && isset( $params['width'] ) &&
(int)$params['width'] > $size['width'] ) {
$params['width'] = $size['width'];
}
--
To view, visit https://gerrit.wikimedia.org/r/278573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6362076e8a24234d2350bc6eb54c81fa9fef04cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
