Yaron Koren has submitted this change and it was merged.
Change subject: Improved some comments
......................................................................
Improved some comments
Change-Id: I153806154c339f5a90b4a1a3a9233044e6f7fa10
---
M includes/SF_FormField.php
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/SF_FormField.php b/includes/SF_FormField.php
index 70bc180..aa06fe9 100644
--- a/includes/SF_FormField.php
+++ b/includes/SF_FormField.php
@@ -7,9 +7,9 @@
/**
* This class is distinct from SFTemplateField in that it represents a template
- * field defined in a form definition - it contains a SFTemplateField object
+ * field defined in a form definition - it contains an SFTemplateField object
* within it (the $template_field variable), along with the other properties
- * for that field that are set within the form
+ * for that field that are set within the form.
* @ingroup SF
*/
class SFFormField {
@@ -32,7 +32,7 @@
// somewhat of a hack - these two fields are for a field in a specific
// representation of a form, not the form definition; ideally these
// should be contained in a third 'field' class, called something like
- // SFFormInstanceField, that holds these fields plus an instance of
+ // SFFormInstanceField, which holds these fields plus an instance of
// SFFormField. Too much work?
private $mInputName;
private $mIsDisabled;
@@ -148,8 +148,8 @@
$field_name = trim( $tag_components[1] );
// See if this field matches one of the fields defined for this
- // template - if it is, use all available information about
- // that field; if it's not, either include it in the form or
+ // template - if it does, use all available information about
+ // that field; if it doesn't, either include it in the form or
// not, depending on whether the template has a 'strict'
// setting in the form definition.
$the_field = null;
--
To view, visit https://gerrit.wikimedia.org/r/278745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I153806154c339f5a90b4a1a3a9233044e6f7fa10
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
