jenkins-bot has submitted this change and it was merged.

Change subject: Fix "No tests found in class …."
......................................................................


Fix "No tests found in class …."

This is a problem since 1dd20e936b1f6dd3efacd155d96d0e0364f66d92 as
PHPUnit_Framework_TestCase doesn't define any tests itself, while
MediaWikiTestCase does.

Change-Id: Ie3a658f254b37e70a06395f8ee7af1c22f71eb28
---
M 
client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
 
b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
index b582c70..df71c49 100644
--- 
a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
+++ 
b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
@@ -19,6 +19,13 @@
                        $this->markTestSkipped( 'Scribunto is not available' );
                }
 
+               public function testPlaceholder() {
+                       $this->assertTrue(
+                               false,
+                               'PHPunit expects this class to have tests. This 
should never run.'
+                       );
+               }
+
        }
 
        return;

-- 
To view, visit https://gerrit.wikimedia.org/r/278757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3a658f254b37e70a06395f8ee7af1c22f71eb28
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to