jenkins-bot has submitted this change and it was merged.
Change subject: Avoid floating elements in aliasesview CSS
......................................................................
Avoid floating elements in aliasesview CSS
This removes a little bit of (mostly invisible) clutter. There is no
need for float. Simply make each alias a block element.
This does make a little *positive* difference in edit mode.
Change-Id: I2fd38dc1c13e06419f8cdf2e53c4c7ecc15a54df
---
M
view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
M view/resources/templates.php
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
index 73a53ae..e71f09b 100644
---
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
+++
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
@@ -93,10 +93,10 @@
.wikibase-entitytermsforlanguagelistview
.wikibase-entitytermsforlanguagelistview-listview
.wikibase-entitytermsforlanguageview
.wikibase-entitytermsforlanguageview-aliases li {
background: none;
border: 0;
- clear: both;
+ display: block;
+ float: none;
margin: 0;
padding: 0;
- width: 100%;
}
.wikibase-entitytermsview
.wikibase-entitytermsview-entitytermsforlanguagelistview
.wikibase-entitytermsforlanguageview
.wikibase-entitytermsforlanguageview-language {
diff --git a/view/resources/templates.php b/view/resources/templates.php
index 2ebbece..dee5602 100644
--- a/view/resources/templates.php
+++ b/view/resources/templates.php
@@ -153,7 +153,7 @@
$templates['wikibase-aliasesview'] =
<<<HTML
<div class="wikibase-aliasesview $1">
- <ul class="wikibase-aliasesview-list" dir="auto">$2</ul>
+ <ul class="wikibase-aliasesview-list" dir="auto"><!-- [0,*]
wikibase-aliasesview-list-item -->$2</ul>
<!-- wikibase-toolbar -->$3
</div>
HTML;
--
To view, visit https://gerrit.wikimedia.org/r/278253
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fd38dc1c13e06419f8cdf2e53c4c7ecc15a54df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Adrian Heine <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
