BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/278984

Change subject: Fix 503 pretty page
......................................................................

Fix 503 pretty page

When nginx precesses the `error_page 503 /admin/?503;` handler directive
it expects to get a 200 response. If the handler decorates itself with
a non-200 response code nginx will assume that the error handler page
itself is broken.

Change-Id: Ibf5cfc8db73ebb70698ba06bf7275675eada5452
---
M www/index.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs 
refs/changes/84/278984/1

diff --git a/www/index.php b/www/index.php
index 040606b..51f938e 100644
--- a/www/index.php
+++ b/www/index.php
@@ -23,7 +23,9 @@
                        header( "Location: $to" );
                        exit( 0 );
                }
-               header( 'HTTP/1.0 503 No Webservice' );
+               // This is endpoint is called as an error hander page by nginx,
+               // so *DO NOT* return an actual 503 status code. If you do 
nginx will
+               // think that the error handler itself is broken.
                include 'content/503.php';
                exit( 0 );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/278984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5cfc8db73ebb70698ba06bf7275675eada5452
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to