Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279072
Change subject: Tiny cleanups
......................................................................
Tiny cleanups
Change-Id: I3ddf124544f3c76296fea46d019ace33642e8298
---
M globalcollect_gateway/globalcollect.adapter.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/72/279072/1
diff --git a/globalcollect_gateway/globalcollect.adapter.php
b/globalcollect_gateway/globalcollect.adapter.php
index bde929f..7758669 100644
--- a/globalcollect_gateway/globalcollect.adapter.php
+++ b/globalcollect_gateway/globalcollect.adapter.php
@@ -1893,7 +1893,7 @@
// FIXME: Move to a more specific point in the workflow, in the
related do_transaction handler.
$this->set3dsFlag();
- // FIXME: Move to a post-staging hook.
+ // FIXME: Move to a post-staging hook, and push most of it into
the declarative block.
$this->tuneForMethod();
$this->tuneForRecurring();
$this->tuneForCountry();
@@ -2070,9 +2070,7 @@
* INSERT_ORDERWITHPAYMENT if the recurring field is populated.
*/
protected function tuneForRecurring(){
- if ( !$this->getData_Unstaged_Escaped( 'recurring' ) ) {
- return;
- } else {
+ if ( $this->getData_Unstaged_Escaped( 'recurring' ) ) {
$this->transactions['INSERT_ORDERWITHPAYMENT']['request']['REQUEST']['PARAMS']['ORDER'][]
= 'ORDERTYPE';
$this->transactions['INSERT_ORDERWITHPAYMENT']['values']['ORDERTYPE'] = '4';
}
--
To view, visit https://gerrit.wikimedia.org/r/279072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ddf124544f3c76296fea46d019ace33642e8298
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
