jenkins-bot has submitted this change and it was merged.
Change subject: Explicitly declare access modifiers
......................................................................
Explicitly declare access modifiers
All these methods and (static) class properties are used as public access
at the moment. So set them explicitly as such.
Change-Id: Ib3bab43a54ce295d4dbfcdaa95450d573699bfb2
---
M Expr.php
M ParserFunctions_body.php
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Expr.php b/Expr.php
index ef98c26..72e82d2 100644
--- a/Expr.php
+++ b/Expr.php
@@ -178,7 +178,7 @@
* @throws ExprError
* @return string
*/
- function doExpression( $expr ) {
+ public function doExpression( $expr ) {
$operands = array();
$operators = array();
@@ -398,7 +398,7 @@
* @param $stack array
* @throws ExprError
*/
- function doOperation( $op, &$stack ) {
+ public function doOperation( $op, &$stack ) {
switch ( $op ) {
case EXPR_NEGATIVE:
if ( count( $stack ) < 1 ) {
diff --git a/ParserFunctions_body.php b/ParserFunctions_body.php
index 2651b06..6612341 100644
--- a/ParserFunctions_body.php
+++ b/ParserFunctions_body.php
@@ -1,10 +1,10 @@
<?php
class ExtParserFunctions {
- static $mExprParser;
- static $mTimeCache = array();
- static $mTimeChars = 0;
- static $mMaxTimeChars = 6000; # ~10 seconds
+ public static $mExprParser;
+ public static $mTimeCache = array();
+ public static $mTimeChars = 0;
+ public static $mMaxTimeChars = 6000; # ~10 seconds
/**
* @param $parser Parser
--
To view, visit https://gerrit.wikimedia.org/r/275795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3bab43a54ce295d4dbfcdaa95450d573699bfb2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ParserFunctions
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
