Niharika29 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279130
Change subject: Change project name to ID in database and make corresponding
changes.
......................................................................
Change project name to ID in database and make corresponding changes.
Reduce redundancy
Change-Id: I13b49573039b8b91739dc326455ee35d095b050f
---
M PageAssessmentsBody.php
M db/addReviewsTable.sql
2 files changed, 7 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments
refs/changes/30/279130/1
diff --git a/PageAssessmentsBody.php b/PageAssessmentsBody.php
index 8c16558..e6c2703 100644
--- a/PageAssessmentsBody.php
+++ b/PageAssessmentsBody.php
@@ -32,7 +32,8 @@
// Compile a list of projects to find out which ones to be
deleted afterwards
$projects = array();
foreach ( $assessmentData as $parserData ) {
- $projects[] = $parserData[0];
+ // Get main page ID for given wikiproject
+ $projects[] = Title::newFromText( 'Wikiproject:' .
$parserData[0] )->getArticleID();
}
$projectsInDb = PageAssessmentsBody::getAllProjects( $pageId );
$toInsert = array_diff( $projects, $projectsInDb );
@@ -42,18 +43,19 @@
foreach ( $assessmentData as $parserData ) {
$project = $parserData[0];
+ $projectId = Title::newFromText( 'Wikiproject:' .
$project )->getArticleID();
$class = $parserData[1];
$importance = $parserData[2];
$values = array(
'pa_page_id' => $pageId,
- 'pa_project' => $project,
+ 'pa_project' => $projectId,
'pa_class' => $class,
'pa_importance' => $importance,
'pa_page_revision' => $revisionId
);
- if ( in_array( $project, $toInsert ) ) {
+ if ( in_array( $projectId, $toInsert ) ) {
$values['job_type'] = 'insert';
- } elseif ( in_array( $project, $toUpdate ) ) {
+ } elseif ( in_array( $projectId, $toUpdate ) ) {
$values['job_type'] = 'update';
}
$jobs[] = new PageAssessmentsSaveJob( $titleObj,
$values );
diff --git a/db/addReviewsTable.sql b/db/addReviewsTable.sql
index 383276b..0e3a796 100644
--- a/db/addReviewsTable.sql
+++ b/db/addReviewsTable.sql
@@ -2,7 +2,7 @@
CREATE TABLE IF NOT EXISTS /*_*/page_assessments (
pa_page_id INT UNSIGNED NOT NULL,
- pa_project VARCHAR(128) DEFAULT NULL,
+ pa_project INT UNSIGNED DEFAULT NULL,
pa_class VARCHAR(20) DEFAULT NULL,
pa_importance VARCHAR(20) DEFAULT NULL,
pa_page_revision INT UNSIGNED NOT NULL
--
To view, visit https://gerrit.wikimedia.org/r/279130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13b49573039b8b91739dc326455ee35d095b050f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
