Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279388
Change subject: Simplify MobileContext::isBlacklistedPageInternal()
......................................................................
Simplify MobileContext::isBlacklistedPageInternal()
Using foreach to re-implement in_array() doesn't seem very intuitive.
Change-Id: I16f68f7784d90e09864aa5437c6f2f6104cb3b22
---
M includes/MobileContext.php
1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/88/279388/1
diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index d972cd3..641f41e 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -474,13 +474,8 @@
}
}
// ...and individual page blacklisting
- if ( $noMobilePages && $title ) {
- $name = $title->getPrefixedText();
- foreach ( $noMobilePages as $page ) {
- if ( $page === $name ) {
- return true;
- }
- }
+ if ( $noMobilePages && $title && in_array(
$title->getPrefixedText(), $noMobilePages ) ) {
+ return true;
}
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/279388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16f68f7784d90e09864aa5437c6f2f6104cb3b22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
