Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279556
Change subject: Add npm entry point
......................................................................
Add npm entry point
Change-Id: Ib3a91d9f5827def8f8fef58f2db18dde824c2697
---
M .gitignore
A .jshintignore
A .jshintrc
M DisqusTag.js
A Gruntfile.js
A package.json
6 files changed, 73 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DisqusTag
refs/changes/56/279556/1
diff --git a/.gitignore b/.gitignore
index e43b0f9..85dd063 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,2 @@
.DS_Store
+node_modules/**
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..3c3629e
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..04c3a97
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,23 @@
+{
+ // Enforcing
+ "bitwise": true,
+ "eqeqeq": true,
+ "freeze": true,
+ "latedef": "nofunc",
+ "noarg": true,
+ "nonew": true,
+ "undef": true,
+ "unused": true,
+ "strict": false,
+
+ // Relaxing
+ "es5": false,
+
+ // Environment
+ "browser": true,
+ "jquery": true,
+
+ "globals": {
+ "mediaWiki": false
+ }
+}
diff --git a/DisqusTag.js b/DisqusTag.js
index e6b0ade..5f5747a 100644
--- a/DisqusTag.js
+++ b/DisqusTag.js
@@ -1,23 +1,23 @@
window.showDisqusDialog = function( id ) {
- $( '#disqus_dialog' ).dialog({ 'width': 800, 'position': 'top' });
+ jQuery( '#disqus_dialog' ).dialog( { 'width': 800, 'position': 'top' }
);
var identifier = url = location.protocol + '//' + location.hostname +
location.pathname + '#!' + id
//Reset Disqus to show the thread corresponding to the clicked button
- DISQUS.reset({
+ DISQUS.reset( {
reload: true,
config: function () {
this.page.identifier = identifier;
this.page.url = url;
}
- });
+ } );
}
-$(function() {
+jQuery( function() {
var disqus = document.createElement( 'script' );
disqus.type = 'text/javascript';
disqus.async = true;
disqus.src = '//' + egDisqusShortname + '.disqus.com/embed.js';
- document.getElementsByTagName( 'body' )[0].appendChild( disqus );
-});
\ No newline at end of file
+ document.getElementsByTagName( 'body' )[ 0 ].appendChild( disqus );
+} );
\ No newline at end of file
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..36b6671
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,30 @@
+/*jshint node:true */
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ grunt.initConfig( {
+ jshint: {
+ options: {
+ jshintrc: true
+ },
+ all: [
+ '**/*.js',
+ '!node_modules/**'
+ ]
+ },
+ banana: {
+ all: 'i18n/'
+ },
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..ec97d7b
--- /dev/null
+++ b/package.json
@@ -0,0 +1,12 @@
+{
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "0.4.5",
+ "grunt-cli": "0.1.13",
+ "grunt-banana-checker": "0.4.0",
+ "grunt-contrib-jshint": "1.0.0",
+ "grunt-jsonlint": "1.0.7"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/279556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3a91d9f5827def8f8fef58f2db18dde824c2697
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DisqusTag
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
