jenkins-bot has submitted this change and it was merged.
Change subject: Explicitly mark SkinTemplate properties as public
......................................................................
Explicitly mark SkinTemplate properties as public
As these are not actually defined in the class but
are used they are effectively public.
There are extensions that use at least 1 of these.
The correct way forward is to now explicitly add
them as public and then deprecate and remove in
the future when needed.
Change-Id: I287579135e29f70437f7e0777fe3dfe524af402e
---
M includes/skins/SkinTemplate.php
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index 419c4b4..5777076 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -45,6 +45,14 @@
*/
public $template = 'QuickTemplate';
+ public $thispage;
+ public $titletxt;
+ public $userpage;
+ public $thisquery;
+ public $loggedin;
+ public $username;
+ public $userpageUrlDetails;
+
/**
* Add specific styles for this skin
*
--
To view, visit https://gerrit.wikimedia.org/r/278880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I287579135e29f70437f7e0777fe3dfe524af402e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
