jenkins-bot has submitted this change and it was merged.
Change subject: Fix regressions in insertables placement
......................................................................
Fix regressions in insertables placement
Most visible one is when opening untranslated message: the buttons
are 30 px too much down. Tweaked the places where the positioning
is updated and made sure the size of correct element is taken.
Change-Id: I065c5d8e5de03a19f0bdceea29cf267d2fba4c24
---
M resources/js/ext.translate.editor.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Santhosh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index 872bd46..139365d 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -581,7 +581,6 @@
if ( original !== '' ) {
$discardChangesButton.removeClass(
'hide' );
- translateEditor.resizeInsertables(
$textarea );
}
/* Avoid Unsaved marking when translated
message is not changed in content.
@@ -606,6 +605,8 @@
$saveButton.prop( 'disabled', true );
$pasteSourceButton.removeClass( 'hide'
);
}
+
+ translateEditor.resizeInsertables( $textarea );
translateEditor.delayValidation( function () {
translateEditor.validateTranslation();
@@ -1053,6 +1054,7 @@
$textarea.focus();
autosize( $textarea );
+ this.resizeInsertables( $textarea );
this.shown = true;
this.$editTrigger.addClass( 'open' );
@@ -1181,7 +1183,7 @@
resizeInsertables: function ( $textarea ) {
var $buttonArea, buttonAreaHeight;
- $buttonArea = $( '.tux-editor-insert-buttons' );
+ $buttonArea = this.$editor.find(
'.tux-editor-insert-buttons' );
buttonAreaHeight = $buttonArea.height();
$textarea.css( 'padding-bottom', buttonAreaHeight + 10
);
$buttonArea.css( 'top', -buttonAreaHeight - 5 );
--
To view, visit https://gerrit.wikimedia.org/r/279639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I065c5d8e5de03a19f0bdceea29cf267d2fba4c24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
