Ferveo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280666
Change subject: Fix spelling mistakes and clarify code comments
......................................................................
Fix spelling mistakes and clarify code comments
No functional changes
Change-Id: I395f97640931d7902cb468d62187d6d8fd10c0b7
---
M modules/jquery.wikiEditor.dialogs.config.js
M modules/jquery.wikiEditor.dialogs.js
M modules/jquery.wikiEditor.js
M modules/jquery.wikiEditor.preview.js
M modules/jquery.wikiEditor.publish.js
5 files changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/66/280666/1
diff --git a/modules/jquery.wikiEditor.dialogs.config.js
b/modules/jquery.wikiEditor.dialogs.config.js
index 42908f5..e970dc3 100644
--- a/modules/jquery.wikiEditor.dialogs.config.js
+++ b/modules/jquery.wikiEditor.dialogs.config.js
@@ -102,7 +102,7 @@
function isExternalLink( s ) {
// The following things are
considered to be external links:
- // * Starts a URL protocol
+ // * Starts with a URL protocol
// * Starts with www.
// All of these are potentially
valid titles, and the latter two categories match about 6300
// titles in enwiki's ns0. Out
of 6.9M titles, that's 0.09%
@@ -136,7 +136,7 @@
}
}
- // Updates the UI to show if the page
title being inputed by the user exists or not
+ // Updates the UI to show if the page
title being inputted by the user exists or not
// accepts parameter internal for
bypassing external link detection
function updateExistence( internal ) {
// ensure the internal
parameter is a boolean
@@ -159,7 +159,7 @@
updateWidget( false );
return;
}
- // If the forced internal
paremter was not true, check if the target is an external link
+ // If the forced internal
parameter was not true, check if the target is an external link
if ( !internal &&
isExternalLink( target ) ) {
updateWidget(
'external' );
return;
diff --git a/modules/jquery.wikiEditor.dialogs.js
b/modules/jquery.wikiEditor.dialogs.js
index 2524807..5adfe1a 100644
--- a/modules/jquery.wikiEditor.dialogs.js
+++ b/modules/jquery.wikiEditor.dialogs.js
@@ -6,7 +6,7 @@
$.wikiEditor.modules.dialogs = {
/**
- * Compatability map
+ * Compatibility map
*/
browsers: {
// Left-to-right languages
@@ -131,7 +131,7 @@
// Add some stuff to configuration
configuration.bgiframe = true;
configuration.autoOpen = false;
- // By default our dialogs are modal, unless explicitely
defined in their specific configuration.
+ // By default our dialogs are modal, unless explicitly
defined in their specific configuration.
if ( typeof configuration.modal === 'undefined' ) {
configuration.modal = true;
}
diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 2d0bf1a..7b481de 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -1,7 +1,7 @@
/**
* This plugin provides a way to build a wiki-text editing user interface
around a textarea.
*
- * @example To intialize without any modules:
+ * @example To initialize without any modules:
* $( 'div#edittoolbar' ).wikiEditor();
*
* @example To initialize with one or more modules, or to add modules after
it's already been initialized:
@@ -38,7 +38,7 @@
$.wikiEditor = {
/**
* For each module that is loaded, static code shared by all instances
is loaded into this object organized by
- * module name. The existance of a module in this object only indicates
the module is available. To check if a
+ * module name. The existence of a module in this object only indicates
the module is available. To check if a
* module is in use by a specific context check the context.modules
object.
*/
modules: {},
@@ -49,15 +49,15 @@
extensions: {},
/**
- * In some cases like with the iframe's HTML file, it's convienent to
have a lookup table of all instances of the
- * WikiEditor. Each context contains an instance field which contains a
key that corrosponds to a reference to the
+ * In some cases like with the iframe's HTML file, it's convenient to
have a lookup table of all instances of the
+ * WikiEditor. Each context contains an instance field which contains a
key that corresponds to a reference to the
* textarea which the WikiEditor was build around. This way, by passing
a simple integer you can provide a way back
* to a specific context.
*/
instances: [],
/**
- * For each browser name, an array of conditions that must be met are
supplied in [operaton, value]-form where
+ * For each browser name, an array of conditions that must be met are
supplied in [operation, value]-form where
* operation is a string containing a JavaScript compatible binary
operator and value is either a number to be
* compared with $.browser.versionNumber or a string to be compared
with $.browser.version. If a browser is not
* specifically mentioned, we just assume things will work.
@@ -106,12 +106,12 @@
/**
* Checks the current browser against the browsers object to determine
if the browser has been black-listed or not.
* Because these rules are often very complex, the object contains
configurable operators and can check against
- * either the browser version number or string. This process also
involves checking if the current browser is amung
- * those which we have configured as compatible or not. If the browser
was not configured as comptible we just go on
+ * either the browser version number or string. This process also
involves checking if the current browser is among
+ * those which we have configured as compatible or not. If the browser
was not configured as compatible we just go on
* assuming things will work - the argument here is to prevent the need
to update the code when a new browser comes
* to market. The assumption here is that any new browser will be built
on an existing engine or be otherwise so
- * similar to another existing browser that things actually do work as
expected. The merrits of this argument, which
- * is essentially to blacklist rather than whitelist are debateable,
but at this point we've decided it's the more
+ * similar to another existing browser that things actually do work as
expected. The merits of this argument, which
+ * is essentially to blacklist rather than whitelist are debatable, but
at this point we've decided it's the more
* "open-web" way to go.
*
* @param {Object} module Module object, defaults to $.wikiEditor
@@ -276,7 +276,7 @@
views: {},
// Container for any number of module-specific data -
only including data for modules in use on this context
modules: {},
- // General place to shouve bits of data into
+ // General place to shove bits of data into
data: {},
// Unique numeric ID of this instance used both for
looking up and differentiating instances of wikiEditor
instance: $.wikiEditor.instances.push( $( this ) ) - 1,
@@ -309,7 +309,7 @@
modules = data;
}
for ( module in modules ) {
- // Check for the existance of an
available / supported module with a matching name and a create function
+ // Check for the existence of an
available / supported module with a matching name and a create function
if ( typeof module === 'string' &&
typeof $.wikiEditor.modules[ module ] !== 'undefined' &&
$.wikiEditor.isSupported( $.wikiEditor.modules[ module ] )
) {
@@ -579,7 +579,7 @@
context.$wikitext.append( $( '<div>' ).addClass(
'wikiEditor-ui-clear' ) );
// Attach a top container to the left pane
context.$wikitext.find( '.wikiEditor-ui-left' ).prepend( $(
'<div>' ).addClass( 'wikiEditor-ui-top' ) );
- // Setup the intial view
+ // Setup the initial view
context.view = 'wikitext';
// Trigger the "resize" event anytime the window is resized
$( window ).resize( function ( event ) {
diff --git a/modules/jquery.wikiEditor.preview.js
b/modules/jquery.wikiEditor.preview.js
index f0a1099..0a050a5 100644
--- a/modules/jquery.wikiEditor.preview.js
+++ b/modules/jquery.wikiEditor.preview.js
@@ -4,7 +4,7 @@
$.wikiEditor.modules.preview = {
/**
- * Compatability map
+ * Compatibility map
*/
browsers: {
// Left-to-right languages
diff --git a/modules/jquery.wikiEditor.publish.js
b/modules/jquery.wikiEditor.publish.js
index 24b2fa3..f7c5f8a 100644
--- a/modules/jquery.wikiEditor.publish.js
+++ b/modules/jquery.wikiEditor.publish.js
@@ -5,7 +5,7 @@
$.wikiEditor.modules.publish = {
/**
- * Compatability map
+ * Compatibility map
*/
browsers: {
// Left-to-right languages
--
To view, visit https://gerrit.wikimedia.org/r/280666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I395f97640931d7902cb468d62187d6d8fd10c0b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Ferveo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
