Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280778
Change subject: Remove $element::$title fallback for TitledElement mixin
......................................................................
Remove $element::$title fallback for TitledElement mixin
This feature has probably never been used, and barely anyone knew about
it. Because it uses the same name as the $title property of
TitledElement, it would be problematic to support when mixins are
converted to use proper PHP traits.
Change-Id: I654e83e07758f01573cb1610ec1b0c830065b1d3
---
M php/mixins/TitledElement.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/78/280778/1
diff --git a/php/mixins/TitledElement.php b/php/mixins/TitledElement.php
index cc0bde0..2065bf9 100644
--- a/php/mixins/TitledElement.php
+++ b/php/mixins/TitledElement.php
@@ -32,8 +32,7 @@
// Initialization
$this->setTitle(
- isset( $config['title'] ) ? $config['title'] :
- ( isset( $element::$title ) ? $element::$title : null )
+ isset( $config['title'] ) ? $config['title'] : null
);
}
--
To view, visit https://gerrit.wikimedia.org/r/280778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I654e83e07758f01573cb1610ec1b0c830065b1d3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
