Tinaj1234 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280837
Change subject: Fixing label of "Manage" button to avoid confusion
......................................................................
Fixing label of "Manage" button to avoid confusion
Changing the label of the "Manage" button to "Collaborators" to
avoid confusion.
Bug: T131457
Change-Id: I6b40a848ef659665dadaaaf66f7531b21a53d59f
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialNewsletter.php
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/37/280837/1
diff --git a/i18n/en.json b/i18n/en.json
index 3ab0bd4..22d207d 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -41,7 +41,7 @@
"newsletter-view-subscriber-count": "Subscriber count:",
"newsletter-view-no-publishers": "No publishers.",
"newsletter-delete-button": "Delete",
- "newsletter-manage-button": "Manage",
+ "newsletter-collaborators-button": "Collaborators",
"newsletter-unsubscribe-button": "Unsubscribe",
"newsletter-subscribe-button": "Subscribe",
"newsletter-announce-button": "Announce",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7f554be..ac0a095 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -45,7 +45,7 @@
"newsletter-view-subscriber-count": "Label for newsletter's subscriber
count field. Shown on Special:Newsletter/<id>.",
"newsletter-view-no-publishers": "Message shown on Special:Newsletter
if there are no publishers for the newsletter.",
"newsletter-delete-button": "Label for \"Delete\" button shown on
Special:Newsletter/<id>. Links to Special:Newsletter/<id>/delete. Only shown if
the current user has permissions to delete the
newsletter.\n{{Identical|Delete}}",
- "newsletter-manage-button": "Label for \"Manage\" button shown on
Special:Newsletter/<id>. Links to Special:Newsletter/<id>/manage. Only shown if
the current user has permissions to manage the newsletter. Manage actions
include adding publishers, removing publishers and announcing new issues.",
+ "newsletter-collaborators-button": "Label for \"Collaborators\" button
shown on Special:Newsletter/<id>. Links to Special:Newsletter/<id>/manage. Only
shown if the current user has permissions to manage the newsletter. Actions
include adding publishers, removing publishers by editing the textbox.",
"newsletter-unsubscribe-button": "Label for \"Unsubscribe\" button
shown on Special:Newsletter/<id>. Links to Special:Newsletter/<id>/unsubscribe.
Shown only for logged-in users and if the user is currently subscribed to the
newsletter.\n{{Identical|Unsubscribe}}",
"newsletter-subscribe-button": "Label for \"Subscribe\" button shown on
Special:Newsletter/<id>. Links to Special:Newsletter/<id>/unsubscribe. Shown
only for logged-in users and if the user is currently not subscribed to the
newsletter.",
"newsletter-announce-button": "Label of \"Announce\" button shown on
Special:Newsletter/id.\n{{Identical|Announce}}",
diff --git a/includes/specials/SpecialNewsletter.php
b/includes/specials/SpecialNewsletter.php
index f77c517..617c44a 100644
--- a/includes/specials/SpecialNewsletter.php
+++ b/includes/specials/SpecialNewsletter.php
@@ -266,7 +266,7 @@
if ( $this->newsletter->canManage( $user ) ) {
$buttons[] = new OOUI\ButtonWidget(
array(
- 'label' => $this->msg(
'newsletter-manage-button' )->escaped(),
+ 'label' => $this->msg(
'newsletter-collaborators-button' )->escaped(),
'icon' => 'settings',
'href' => $this->getPageTitle( $id .
'/' . self::NEWSLETTER_MANAGE )->getFullURL()
)
@@ -668,7 +668,7 @@
->rawParams( $this->getEscapedName() )->parse()
);
$form->setId( 'newsletter-manage-form' );
- $form->setSubmitID( 'newsletter-manage-button' );
+ $form->setSubmitID( 'newsletter-collaborators-button' );
$form->setSubmitTextMsg( 'newsletter-managenewsletter-button' );
$form->show();
}
--
To view, visit https://gerrit.wikimedia.org/r/280837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b40a848ef659665dadaaaf66f7531b21a53d59f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Tinaj1234 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
