Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281183
Change subject: Only detect plain external links if they have href's
......................................................................
Only detect plain external links if they have href's
We now accept non-Parsoid generated external links from
paste, so make sure they have href's otherwise they aren't
really external links and will throw exceptions later on.
Bug: T131430
Change-Id: Ifb565b1ce30cfe80ae72b17f6a9551ea40b36453
---
M modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/83/281183/1
diff --git a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
index a5e6887..13a24a5 100644
--- a/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
+++ b/modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js
@@ -35,8 +35,8 @@
ve.dm.MWExternalLinkAnnotation.static.matchFunction = function ( domElement ) {
var rel = domElement.getAttribute( 'rel' );
- // Match explicity mw:ExtLink, or plain RDFa-less links (e.g. from
external paste)
- return !rel || rel === 'mw:ExtLink';
+ // Match explicity mw:ExtLink, or plain RDFa-less links with href's
(e.g. from external paste)
+ return ( !rel && domElement.hasAttribute( 'href' ) ) || rel ===
'mw:ExtLink';
};
ve.dm.MWExternalLinkAnnotation.static.toDataElement = function ( domElements,
converter ) {
--
To view, visit https://gerrit.wikimedia.org/r/281183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb565b1ce30cfe80ae72b17f6a9551ea40b36453
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
