Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281187
Change subject: Fix regression from 0fc63bde365: unbreak number formatting in
short timestamps
......................................................................
Fix regression from 0fc63bde365: unbreak number formatting in short timestamps
We were using momentjs here before (causing bug T123845),
but we switched to using a hack for short timestamps.
This hack didn't call convertNumber(), so we stopped performing
number formatting for languages that don't use Western Arabic
numerals (0-9).
Strictly, that regression "fixed" T123845 because it caused
0-9 to be used in all cases, including the case that that bug
asked for. This patch fixes the regression but preserves the
desired behavior for arwiki, since convertNumber() respects
$wgTranslateNumerals.
Bug: T123845
Change-Id: Ic9acb12f534e0f049e22577afe276f8bf68f691d
---
M modules/ext.echo.init.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/87/281187/1
diff --git a/modules/ext.echo.init.js b/modules/ext.echo.init.js
index 3d08677..2b64320 100644
--- a/modules/ext.echo.init.js
+++ b/modules/ext.echo.init.js
@@ -64,7 +64,7 @@
y: 'years',
yy: 'years'
};
- return mw.msg(
'notification-timestamp-ago-' + keymap[ key ], number );
+ return mw.msg(
'notification-timestamp-ago-' + keymap[ key ], mw.language.convertNumber(
number ) );
} } );
// Reset back to original locale
moment.locale( momentOrigLocale );
--
To view, visit https://gerrit.wikimedia.org/r/281187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9acb12f534e0f049e22577afe276f8bf68f691d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
