Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281269
Change subject: build: Fix Gruntfile to actually parse JS files
......................................................................
build: Fix Gruntfile to actually parse JS files
Also take the opportunity to use 'mw' not 'mediaWiki' per conventions.
Change-Id: Icf94075758bde013cfd1aa46e1761155ddfa5c14
---
M .jshintrc
M Gruntfile.js
M modules/article/ext.proofreadpage.article.js
M modules/index/ext.proofreadpage.index.js
M modules/page/ext.proofreadpage.page.edit.js
M modules/page/ext.proofreadpage.page.navigation.js
6 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/69/281269/1
diff --git a/.jshintrc b/.jshintrc
index d3e70a4..27e9c99 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -11,11 +11,10 @@
"unused": true,
// Environment
+ "jquery": true,
"browser": true,
"globals": {
- "mediaWiki": false,
- "jQuery": false
+ "mw": false
}
}
-
diff --git a/Gruntfile.js b/Gruntfile.js
index d4900cf..84891f2 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -11,7 +11,8 @@
jshintrc: true
},
all: [
- '**/*.js',
+ '*.js',
+ 'modules/**/*.js',
'!modules/jquery/*.js',
'!node_modules/**',
'!vendor/**'
diff --git a/modules/article/ext.proofreadpage.article.js
b/modules/article/ext.proofreadpage.article.js
index d3c07cc..24f45e3 100644
--- a/modules/article/ext.proofreadpage.article.js
+++ b/modules/article/ext.proofreadpage.article.js
@@ -6,4 +6,4 @@
$( '#ca-nstab-main' ).after( '<li
id="ca-proofread-source"><span>' + mw.config.get( 'proofreadpage_source_href' )
+ '</span></li>' );
} );
-}( mediaWiki, jQuery ) );
+}( mw, jQuery ) );
diff --git a/modules/index/ext.proofreadpage.index.js
b/modules/index/ext.proofreadpage.index.js
index 4610eff..20c33c2 100644
--- a/modules/index/ext.proofreadpage.index.js
+++ b/modules/index/ext.proofreadpage.index.js
@@ -8,4 +8,4 @@
} );
} );
-}( mediaWiki, jQuery ) );
+}( mw, jQuery ) );
diff --git a/modules/page/ext.proofreadpage.page.edit.js
b/modules/page/ext.proofreadpage.page.edit.js
index da2cad1..dce382c 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -268,4 +268,4 @@
initZoom();
} );
-}( mediaWiki, jQuery ) );
+}( mw, jQuery ) );
diff --git a/modules/page/ext.proofreadpage.page.navigation.js
b/modules/page/ext.proofreadpage.page.navigation.js
index e6a8325..dbd374b 100644
--- a/modules/page/ext.proofreadpage.page.navigation.js
+++ b/modules/page/ext.proofreadpage.page.navigation.js
@@ -46,4 +46,4 @@
initTabs();
} );
-}( mediaWiki, jQuery ) );
+}( mw, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/281269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf94075758bde013cfd1aa46e1761155ddfa5c14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
