Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/281302

Change subject: Uses mw.toolbar to create old toolbar buttons for page pages
......................................................................

Uses mw.toolbar to create old toolbar buttons for page pages

Change-Id: I96905d632b2f6b37d59aa201751d47ebb99bfad8
---
M modules/page/ext.proofreadpage.page.edit.js
1 file changed, 6 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/02/281302/1

diff --git a/modules/page/ext.proofreadpage.page.edit.js 
b/modules/page/ext.proofreadpage.page.edit.js
index dce382c..e75929e 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -190,22 +190,14 @@
                                } );
                        } );
                } else if ( mw.user.options.get( 'showtoolbar' ) === 1 ) {
-                       mw.loader.using( 'mediawiki.action.edit', function () {
-                               var $toolbar = $( '#toolbar' );
-
+                       mw.loader.using( 'mediawiki.toolbar', function () {
                                $.each( tools, function ( group, list ) {
                                        $.each( list.tools, function ( id, def 
) {
-                                               $( '<img>' )
-                                                       .attr( {
-                                                               width: 23,
-                                                               height: 22,
-                                                               src: 
def.oldIcon,
-                                                               alt: mw.msg( 
def.labelMsg ),
-                                                               title: mw.msg( 
def.labelMsg ),
-                                                               'class': 
'mw-toolbar-editbutton' // quotes needed for IE
-                                                       } )
-                                                       .click( 
def.action.execute )
-                                                       .appendTo( $toolbar );
+                                               mw.toolbar.addButton( {
+                                                       imageFile: def.oldIcon,
+                                                       speedTip: mw.msg( 
def.labelMsg ),
+                                                       onClick: 
def.action.execute
+                                               } );
                                        } );
                                } );
                        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/281302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96905d632b2f6b37d59aa201751d47ebb99bfad8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to