VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281860
Change subject: Lower specificity of CSS type attribute selectors
......................................................................
Lower specificity of CSS type attribute selectors
Lowering various `[type]` selectors specificity, where applicable,
from 0-0-1-1 to 0-0-1-0 by removing unnecessary element.
Also improving comments for unification.
Change-Id: I9b949b67eaef49fe291c9c0d4c490456bef84190
---
M resources/src/mediawiki.legacy/shared.css
M resources/src/mediawiki.less/mediawiki.ui/mixins.less
M resources/src/mediawiki.special/mediawiki.special.block.css
M resources/src/mediawiki.ui/components/checkbox.less
M resources/src/mediawiki.ui/components/forms.less
M resources/src/mediawiki.ui/components/inputs.less
M resources/src/mediawiki.ui/components/radio.less
7 files changed, 17 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/281860/1
diff --git a/resources/src/mediawiki.legacy/shared.css
b/resources/src/mediawiki.legacy/shared.css
index daebac1..eb7116c 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -56,22 +56,22 @@
/* Input types that should follow user direction, like buttons */
/* TODO: What about buttons in wikipage content ? */
-input[type="submit"],
-input[type="button"],
-input[type="reset"],
-input[type="file"] {
+input[type=submit],
+input[type=button],
+input[type=reset],
+[type=file] {
direction: ltr;
}
/* Override default values */
-textarea[dir="ltr"],
-input[dir="ltr"] {
+textarea[dir=ltr],
+input[dir=ltr] {
/* @noflip */
direction: ltr;
}
-textarea[dir="rtl"],
-input[dir="rtl"] {
+textarea[dir=rtl],
+input[dir=rtl] {
/* @noflip */
direction: rtl;
}
diff --git a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
index 12825de..d091862 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
@@ -15,11 +15,10 @@
cursor: pointer;
vertical-align: bottom;
line-height: normal;
-
font-weight: normal;
- & > input[type="checkbox"],
- & > input[type="radio"] {
+ & > [type=checkbox],
+ & > [type=radio] {
width: auto;
height: auto;
margin: 0 0.1em 0 0;
diff --git a/resources/src/mediawiki.special/mediawiki.special.block.css
b/resources/src/mediawiki.special/mediawiki.special.block.css
index a30a15d..65410a8 100644
--- a/resources/src/mediawiki.special/mediawiki.special.block.css
+++ b/resources/src/mediawiki.special/mediawiki.special.block.css
@@ -2,7 +2,7 @@
* Styling for Special:Block
*/
-label[for="mw-input-wpConfirm"] {
+label[for=mw-input-wpConfirm] {
font-weight: bold;
}
diff --git a/resources/src/mediawiki.ui/components/checkbox.less
b/resources/src/mediawiki.ui/components/checkbox.less
index b0fbf51..fd592e4 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -48,7 +48,7 @@
vertical-align: middle;
}
- input[type="checkbox"] {
+ [type=checkbox] {
// we hide the input element as instead we will style the label
that follows
// we use opacity so that VoiceOver software can still identify
it
opacity: 0;
diff --git a/resources/src/mediawiki.ui/components/forms.less
b/resources/src/mediawiki.ui/components/forms.less
index cc96a5c..fef1b7b 100644
--- a/resources/src/mediawiki.ui/components/forms.less
+++ b/resources/src/mediawiki.ui/components/forms.less
@@ -66,7 +66,7 @@
}
// Override input styling just for checkboxes and radio inputs.
- input[type="radio"] {
+ [type=radio] {
display: inline;
.box-sizing( content-box );
width: auto;
diff --git a/resources/src/mediawiki.ui/components/inputs.less
b/resources/src/mediawiki.ui/components/inputs.less
index d0633ae..6b4f82a 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -27,7 +27,7 @@
//
// Styleguide 1.1.
.mw-ui-input {
- // turn off default input styling for input[type="search"] fields
+ // turn off default input styling for input[type=search] fields
-webkit-appearance: none;
.box-sizing( border-box );
display: block;
@@ -66,7 +66,7 @@
box-shadow: inset 0 0 0 2px @colorProgressive;
// Color being used to match inset shadow, not semantic reasons
border-color: @colorProgressive;
- // Remove focus glow on input[type="search"]
+ // Remove focus glow on input[type=search]
outline: 0;
}
@@ -89,7 +89,7 @@
// <button class="mw-ui-button mw-ui-constructive">Submit</button>
//
// Styleguide 1.2.
-input[type="number"],
+[type=number],
.mw-ui-input-inline {
display: inline-block;
width: auto;
diff --git a/resources/src/mediawiki.ui/components/radio.less
b/resources/src/mediawiki.ui/components/radio.less
index 53c22b44..7c679f9 100644
--- a/resources/src/mediawiki.ui/components/radio.less
+++ b/resources/src/mediawiki.ui/components/radio.less
@@ -48,7 +48,7 @@
vertical-align: middle;
}
- input[type="radio"] {
+ [type=radio] {
// we hide the input element as instead we will style the label
that follows
// we use opacity so that VoiceOver software can still identify
it
opacity: 0;
--
To view, visit https://gerrit.wikimedia.org/r/281860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b949b67eaef49fe291c9c0d4c490456bef84190
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
