jenkins-bot has submitted this change and it was merged.
Change subject: Use PHPUnit's fail() instead of assertTrue( false )
......................................................................
Use PHPUnit's fail() instead of assertTrue( false )
Change-Id: I3b677b89b89b3fba4cc80cc8883aa2e832a9d832
---
M
client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
M client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
index df71c49..c252ea2 100644
---
a/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
+++
b/client/tests/phpunit/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTestCase.php
@@ -20,10 +20,7 @@
}
public function testPlaceholder() {
- $this->assertTrue(
- false,
- 'PHPunit expects this class to have tests. This
should never run.'
- );
+ $this->fail( 'PHPunit expects this class to have tests.
This should never run.' );
}
}
diff --git
a/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
b/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
index 6cf8686..923ba90 100644
--- a/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
+++ b/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
@@ -218,7 +218,7 @@
$this->mergeMwGlobalArrayValue( 'wgHooks', array(
'WikibaseClientOtherProjectsSidebar' => array(
function () {
- $this->assertTrue( false, 'Should not
get called.' );
+ $this->fail( 'Should not get called.' );
},
),
) );
--
To view, visit https://gerrit.wikimedia.org/r/281954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b677b89b89b3fba4cc80cc8883aa2e832a9d832
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
