Alexandros Kosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282104

Change subject: Add a comment about the lvs_grain's information purposes
......................................................................

Add a comment about the lvs_grain's information purposes

The newly added lvs_grain, while great for operational purposes, is not
a knob but only an indicator. point that out in a comment

Change-Id: If11281d5eb7b6223ab2d8f9e5f0cabd29ee4732c
---
M modules/lvs/manifests/configuration.pp
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/04/282104/1

diff --git a/modules/lvs/manifests/configuration.pp 
b/modules/lvs/manifests/configuration.pp
index facbcbe..982c683 100644
--- a/modules/lvs/manifests/configuration.pp
+++ b/modules/lvs/manifests/configuration.pp
@@ -51,6 +51,8 @@
         $v6_ip = '::'
     }
 
+    # NOTE: This is for informational purposes only. The actual configuration
+    # that decides primary/secondary is done at the BGP level on the routers.
     $lvs_grain = $::hostname ? {
         /^lvs100[123789]$/ => 'primary',
         /^lvs200[123]$/    => 'primary',

-- 
To view, visit https://gerrit.wikimedia.org/r/282104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If11281d5eb7b6223ab2d8f9e5f0cabd29ee4732c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to