jenkins-bot has submitted this change and it was merged.
Change subject: Close HTTP connection when downloading saved pages
......................................................................
Close HTTP connection when downloading saved pages
Close the HTTP client connection after downloading an image. This fixes
the following scenario:
1 Tap random until a page with a lead image is shown.
2 Tap save.
3 Quickly tap random. The following message is logged:
OkHttpClient W A connection to https://upload.wikimedia.org/ was leaked.
Did you forget to close a response body?
Change-Id: I300fc1e6d278356d5c28e0152a65fc69a3a8075d
---
M app/src/main/java/org/wikipedia/savedpages/DownloadImageTask.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Mholloway: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/savedpages/DownloadImageTask.java
b/app/src/main/java/org/wikipedia/savedpages/DownloadImageTask.java
index cffa02d..7c4c3a7 100644
--- a/app/src/main/java/org/wikipedia/savedpages/DownloadImageTask.java
+++ b/app/src/main/java/org/wikipedia/savedpages/DownloadImageTask.java
@@ -46,9 +46,11 @@
if (request.ok()) {
writeFile(request.stream(), file);
Log.d(TAG, "downloaded image " + url + " to " +
file.getAbsolutePath());
+ request.stream().close();
return true;
} else {
Log.e(TAG, "could not download image " + url + " to " +
file.getAbsolutePath());
+ request.stream().close();
return false;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/281381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I300fc1e6d278356d5c28e0152a65fc69a3a8075d
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
