Filippo Giunchedi has submitted this change and it was merged. Change subject: remove query parms from urls ......................................................................
remove query parms from urls The idea here was to produce Icinga alerts with a URL that would take you straight to the relevant panel in a Grafana dashboard, but sanitization somewhere along the way is mangling them: https://grafana.wikimedia.org/dashboard/db/restbase-from-now-6h-panelId-14-fullscreen Since noone cared for my url shortener idea... Change-Id: Ic4b140f23ae1b1848f0b70e009338f8e609f050b --- M manifests/role/restbase.pp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Filippo Giunchedi: Verified; Looks good to me, approved diff --git a/manifests/role/restbase.pp b/manifests/role/restbase.pp index 523aa59..ce805ef 100644 --- a/manifests/role/restbase.pp +++ b/manifests/role/restbase.pp @@ -21,7 +21,7 @@ class role::restbase::alerts { monitoring::graphite_threshold { 'restbase_request_5xx_rate': - description => 'RESTBase html revision 5xx req/s https://grafana.wikimedia.org/dashboard/db/restbase?from=now-6h&panelId=14&fullscreen', + description => 'RESTBase html revision 5xx req/s https://grafana.wikimedia.org/dashboard/db/restbase', metric => 'transformNull(restbase.external.v1_page_html_-title-_-revision--_tid-.GET.5xx.sample_rate, 0)', from => '10min', warning => '1', # 1 5xx/s @@ -31,7 +31,7 @@ } monitoring::graphite_threshold { 'restbase_html_storage_hit_latency': - description => 'RESTBase HTML revision request mean storage latency ms https://grafana.wikimedia.org/dashboard/db/restbase?from=now-6h&panelId=11&fullscreen', + description => 'RESTBase HTML revision request mean storage latency ms https://grafana.wikimedia.org/dashboard/db/restbase', metric => 'movingMedian(restbase.external.sys_key-rev-value_-bucket-_-key--_revision--_tid-.GET.2xx.mean, 15)', from => '10min', warning => '25', # 25ms @@ -41,7 +41,7 @@ } monitoring::graphite_threshold { 'restbase_html_storage_hit_latency_99p': - description => 'RESTBase HTML revision request 99p storage latency ms https://grafana.wikimedia.org/dashboard/db/restbase?from=now-6h&panelId=11&fullscreen', + description => 'RESTBase HTML revision request 99p storage latency ms https://grafana.wikimedia.org/dashboard/db/restbase', metric => 'movingMedian(restbase.external.sys_key-rev-value_-bucket-_-key--_revision--_tid-.GET.2xx.p99, 15)', from => '10min', warning => '1500', # 1.5s -- To view, visit https://gerrit.wikimedia.org/r/282174 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b140f23ae1b1848f0b70e009338f8e609f050b Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Eevans <[email protected]> Gerrit-Reviewer: Alexandros Kosiaris <[email protected]> Gerrit-Reviewer: Filippo Giunchedi <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]> Gerrit-Reviewer: Mobrovac <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
