Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282204

Change subject: Use getUrl from mw.Title to generate the URL
......................................................................

Use getUrl from mw.Title to generate the URL

This allows to create articles with dot in the name like [[Node.js]].

Change-Id: Icb6bca4928c0c60c719dd3172972f544c3673d3b
---
M extension.json
M modules/ext.articleplaceholder.createArticle.js
2 files changed, 3 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder 
refs/changes/04/282204/1

diff --git a/extension.json b/extension.json
index 9987456..cc20541 100644
--- a/extension.json
+++ b/extension.json
@@ -34,8 +34,7 @@
                        "dependencies": [
                                "oojs-ui",
                                "mediawiki.api",
-                               "mediawiki.Title",
-                               "mediawiki.util"
+                               "mediawiki.Title"
                        ],
                        "messages": [
                                "articleplaceholder-abouttopic-create-article",
diff --git a/modules/ext.articleplaceholder.createArticle.js 
b/modules/ext.articleplaceholder.createArticle.js
index 68c77c9..9f3d1a4 100644
--- a/modules/ext.articleplaceholder.createArticle.js
+++ b/modules/ext.articleplaceholder.createArticle.js
@@ -23,8 +23,7 @@
                                titles: titleRaw
                        } ).done( function ( data ) {
                                var query = data.query,
-                                       title,
-                                       link;
+                                       title;
 
                                if ( query && query.hasOwnProperty( 'pages' ) ) 
{
                                        if ( titleRaw !== titleInput.getValue() 
) {
@@ -33,9 +32,7 @@
 
                                        if ( query.pages[ 0 ].missing ) {
                                                title = 
mw.Title.newFromUserInput( titleRaw, 0 );
-                                               link = '?title=' + 
encodeURIComponent( title.getNameText() ) + '&action=edit';
-                                               link = mw.util.wikiScript() + 
link;
-                                               document.location.href = link;
+                                               document.location.href = 
title.getUrl( { action: 'edit' } );
                                        } else {
                                                deferred.reject( new 
OO.ui.Error(
                                                        mw.msg( 
'articleplaceholder-abouttopic-article-exists-error' )

-- 
To view, visit https://gerrit.wikimedia.org/r/282204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb6bca4928c0c60c719dd3172972f544c3673d3b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to