BBlack has submitted this change and it was merged.
Change subject: secure GeoIP cookie T119576
......................................................................
secure GeoIP cookie T119576
Change-Id: I7e510ba00fe49a8aa834e392791cbbb88f850861
---
M templates/varnish/geoip.inc.vcl.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Reedy: Looks good to me, but someone else must approve
BBlack: Verified; Looks good to me, approved
diff --git a/templates/varnish/geoip.inc.vcl.erb
b/templates/varnish/geoip.inc.vcl.erb
index 3101182..7f60e6f 100644
--- a/templates/varnish/geoip.inc.vcl.erb
+++ b/templates/varnish/geoip.inc.vcl.erb
@@ -220,7 +220,7 @@
// Use libvmod-header to ensure the Set-Cookie header
we are adding does not
// clobber or manipulate existing cookie headers (if
any).
- Vmod_Func_header.append(sp, HDR_RESP,
"\013Set-Cookie:", cookie_buf, "; Path=/; Domain=.",
+ Vmod_Func_header.append(sp, HDR_RESP,
"\013Set-Cookie:", cookie_buf, "; Path=/; secure; Domain=.",
host_safe, vrt_magic_string_end);
}
}C
--
To view, visit https://gerrit.wikimedia.org/r/281980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e510ba00fe49a8aa834e392791cbbb88f850861
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Ema <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
