jenkins-bot has submitted this change and it was merged.
Change subject: Collect impact of proposed ResourceLoader feature-test in statsd
......................................................................
Collect impact of proposed ResourceLoader feature-test in statsd
The sample factor of 1:1000 matches the ratio we currently use for collecting
Navigation Timing metrics.
This is a lightweight tracker that sends a beacon straight to statsv,
without the overhead of an EventLogging schema.
To get an idea of common user agents that don't pass, I plan to collect
samples from the kafka 'statsv' topic directly.
Bug: T128924
Change-Id: I672624e9fc3044c0dc024fa5097932c00f38d6db
---
M extension.json
A modules/ext.wikimediaEvents.rlfeature.js
2 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 56c82e8..4003ed3 100644
--- a/extension.json
+++ b/extension.json
@@ -128,11 +128,13 @@
"ext.wikimediaEvents": {
"scripts": [
"ext.wikimediaEvents.statsd.js",
+ "ext.wikimediaEvents.rlfeature.js",
"ext.wikimediaEvents.searchSatisfaction.js",
"ext.wikimediaEvents.search.js",
"ext.wikimediaEvents.geoFeatures.js"
],
"dependencies": [
+ "ext.eventLogging.subscriber",
"mediawiki.user",
"mediawiki.Uri",
"mediawiki.storage"
diff --git a/modules/ext.wikimediaEvents.rlfeature.js
b/modules/ext.wikimediaEvents.rlfeature.js
new file mode 100644
index 0000000..8650de2
--- /dev/null
+++ b/modules/ext.wikimediaEvents.rlfeature.js
@@ -0,0 +1,29 @@
+/*!
+ * Measure pass/fail rate of a proposed feature test for ResourceLoader
+ * that would replace the current User-Agent sniffing.
+ *
+ * https://phabricator.wikimedia.org/T128924
+ * https://phabricator.wikimedia.org/T102318
+ */
+( function ( mw ) {
+ // Filter: Sample 1 in 1000 page views
+ if ( !mw.eventLog.inSample( 1000 ) ) {
+ return;
+ }
+
+ var supported = (
+ // DOM4 (Selectors API Level 1)
+ 'querySelector' in document
+ // HTML5 (Web Storage)
+ && 'localStorage' in window
+ // DOM2 (DOM Level 2 Events)
+ && 'addEventListener' in window
+ );
+
+ if ( supported ) {
+ mw.track( 'counter.mw.js.rlfeature2016.pass', 1 );
+ } else {
+ mw.track( 'counter.mw.js.rlfeature2016.fail', 1 );
+ }
+
+}( mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/280372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I672624e9fc3044c0dc024fa5097932c00f38d6db
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
