jenkins-bot has submitted this change and it was merged.
Change subject: Fix mbstring check in update.php
......................................................................
Fix mbstring check in update.php
Maintenance::error() will not cause the script to exit unless the
$die argument, when cast as an integer, is greater than 0. Since
the default value is 0, specify a different one, as in the other
calls from within the same function.
Follows-up 943563062f0a6995.
Change-Id: I3af72b1cd87c63d7f57436866633e86c272e904f
---
M maintenance/update.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/update.php b/maintenance/update.php
index e487449..775fa7b 100755
--- a/maintenance/update.php
+++ b/maintenance/update.php
@@ -87,7 +87,8 @@
if ( !function_exists( 'mb_strlen' ) ) {
$this->error(
"MediaWiki now requires the mbstring PHP
extension, your system doesn't have it.\n"
- . "ABORTING.\n" );
+ . "ABORTING.\n",
+ true );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/282307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3af72b1cd87c63d7f57436866633e86c272e904f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
