Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282454
Change subject: Cleanup code
......................................................................
Cleanup code
Change-Id: I7327a401d3f9ba448da9d5e184194d7556214461
---
M imagereview.py
1 file changed, 6 insertions(+), 31 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/bots/xqbot
refs/changes/54/282454/1
diff --git a/imagereview.py b/imagereview.py
index d8c7b6c..1459112 100644
--- a/imagereview.py
+++ b/imagereview.py
@@ -274,8 +274,8 @@
class CheckImageBot(object):
- # Edit summary message that should be used.
- # NOTE: Put a good description here, and add translations, if possible!
+
+ """Bot to review uploaded Files."""
availableOptions = {
'list': None, # list unreferenced Files
@@ -554,12 +554,9 @@
where = u'Mail'
else:
pywikibot.output(u'%s has mail disabled.' % user)
- # if not self.save(pywikibot.Page(self.site, self.dest,
defaultNamespace=3), text): return False
+
if not where:
- if not upm.isRegistered():
- where = u'Unbekannt'
- else:
- where = u'Gar nicht'
+ where = 'Unbekannt' if not upm.isRegistered() else 'Gar nicht'
# jetzt alle Dateien eines Benutzers bearbeiten
for i in images:
@@ -732,7 +729,6 @@
"%s:%s" % (self.site.category_namespace(),
self.cat))
gen = pagegenerators.SubCategoriesPageGenerator(cat)
- # gen = pagegenerators.RegexFilterPageGenerator(gen, )
gen = pagegenerators.PreloadingGenerator(gen)
for c in gen:
self.touch(c)
@@ -781,10 +777,6 @@
else:
pywikibot.output(u'Uploader %s is not listed' % key)
cattext = self.add_uploader_info(cattext, key, table[key])
-## cattext += u'\n== [[Benutzer:%s|]] ==\n\n' % key
-## for image in table[key]:
-## cattext += u'{{Dateiüberprüfung (Liste)|1=%s|2=%s}}\n' \
-## % (image.title(), key)
change = True
if change:
self.save(cat, cattext, u'Bot: Ergänze Dateien mit Aufschub')
@@ -803,13 +795,12 @@
return text
def review(self, image):
- """
- Loads the given page, does some changes, and saves it.
- """
+ """Check whether page was transcluded previously."""
imageID = None
linked = []
found = False
vh = image.getVersionHistory()
+ # Search for last bot action
for oldid, time, username, summary, size, tags in vh:
if username in [u'Xqbot', u'BLUbot']:
imageID = oldid
@@ -899,22 +890,6 @@
# manuell nacharbeiten?
# oder erledigen
pass
-"""
-code-Schnippel zur Abarbeitung der Review nötig-Kat:
-cat = cl.Category('de',
u'Kategorie:Wikipedia:Dateiüberprüfung/Verwendungsreview nötig')
-for c in gen:
- i = wp.ImagePage('de', c.title())
- used = False
- for ref in i.usingPages():
- wp.output(u'%s used in %s' % (i.title(), ref.title()))
- used = True
- break
- if used:
- info = i.get()
- info =
re.sub(u'(?s)\{\{#ifeq:\{\{NAMESPACE\}\}\|\{\{ns:6\}\}\|.+?\[\[[^\[]+?/Verwendungsreview[^\]]*?\]\]\r?\n\}\}\r?\n?',
u'', info)
- summary = u'Bot: Datei wird bereits verwendet, Verwendungs-Review
abgeschlossen.'
- i.put(info, summary)
-""" # noqa
def main(*args):
--
To view, visit https://gerrit.wikimedia.org/r/282454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7327a401d3f9ba448da9d5e184194d7556214461
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
