Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/282474
Change subject: Remove unnecessary phpcs overrides ...................................................................... Remove unnecessary phpcs overrides Change-Id: Ic7648c14f2ac2a07878f69e102832215af6855c8 --- M AbuseFilter.parser.php M AbuseFilterTokenizer.php 2 files changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter refs/changes/74/282474/1 diff --git a/AbuseFilter.parser.php b/AbuseFilter.parser.php index 1ef3a1e..05dcc7e 100644 --- a/AbuseFilter.parser.php +++ b/AbuseFilter.parser.php @@ -1305,9 +1305,7 @@ case AFPToken::TSQUAREBRACKET: if ( $this->mCur->value == '[' ) { $list = array(); - // @codingStandardsIgnoreStart Space beforsemi-colon ignored. - for ( ; ; ) { - // @codingStandardsIgnoreEnd + while ( true ) { $this->move(); if ( $this->mCur->type == AFPToken::TSQUAREBRACKET && $this->mCur->value == ']' ) { break; @@ -1662,9 +1660,7 @@ static $replacementArray = null; if ( is_null( $replacementArray ) ) { - // @codingStandardsIgnoreStart Ignore global without wg prefix. global $IP; - // @codingStandardsIgnoreEnd if ( is_readable( "$IP/extensions/AntiSpoof/equivset.php" ) ) { // Satisfy analyzer. diff --git a/AbuseFilterTokenizer.php b/AbuseFilterTokenizer.php index b76d7ec..1a6a2b6 100644 --- a/AbuseFilterTokenizer.php +++ b/AbuseFilterTokenizer.php @@ -7,9 +7,8 @@ const CACHE_VERSION = 1; const COMMENT_START_RE = '/\s*\/\*/A'; const ID_SYMBOL_RE = '/[0-9A-Za-z_]+/A'; - // @codingStandardsIgnoreStart Ignore long line. - const OPERATOR_RE = '/(\!\=\=|\!\=|\!|\*\*|\*|\/|\+|\-|%|&|\||\^|\:\=|\?|\:|\<\=|\<|\>\=|\>|\=\=\=|\=\=|\=)/A'; - // @codingStandardsIgnoreEnd + const OPERATOR_RE = + '/(\!\=\=|\!\=|\!|\*\*|\*|\/|\+|\-|%|&|\||\^|\:\=|\?|\:|\<\=|\<|\>\=|\>|\=\=\=|\=\=|\=)/A'; const RADIX_RE = '/([0-9A-Fa-f]+(?:\.\d*)?|\.\d+)([bxo])?/Au'; const WHITESPACE = "\011\012\013\014\015\040"; -- To view, visit https://gerrit.wikimedia.org/r/282474 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7648c14f2ac2a07878f69e102832215af6855c8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits