jenkins-bot has submitted this change and it was merged.
Change subject: SpecialLog: Don't put assignment within another expression
......................................................................
SpecialLog: Don't put assignment within another expression
Change-Id: I0a0cd9ee0647e8778d2e835cc02c571a83b3a8c2
---
M includes/specials/SpecialLog.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialLog.php b/includes/specials/SpecialLog.php
index 7132207..85728ef 100644
--- a/includes/specials/SpecialLog.php
+++ b/includes/specials/SpecialLog.php
@@ -147,7 +147,8 @@
private function parseParams( FormOptions $opts, $par ) {
# Get parameters
- $parms = explode( '/', ( $par = ( $par !== null ) ? $par : '' )
);
+ $par = $par !== null ? $par : '';
+ $parms = explode( '/', $par );
$symsForAll = [ '*', 'all' ];
if ( $parms[0] != '' &&
( in_array( $par, $this->getConfig()->get( 'LogTypes' )
) || in_array( $par, $symsForAll ) )
--
To view, visit https://gerrit.wikimedia.org/r/281735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a0cd9ee0647e8778d2e835cc02c571a83b3a8c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
