Ori.livneh has submitted this change and it was merged. Change subject: Add initial GuidedTour tests, with related refactoring. ......................................................................
Add initial GuidedTour tests, with related refactoring. * Break ext.guidedTour into two modules, one with the main code, and one that implicitly launches a tour from the environment. This eases testability. * Remove some unneeded semi-global (whole ext.guidedTour scope) variables. * Various small fixes, including a couple that are also in other pending changes. * Coding convention and documentation improvements. Change-Id: I604dcc7f41a1ece1fefc8f1ed0d5a78dc5946aa4 --- M GuidedTour.php M GuidedTourHooks.php M modules/ext.guidedTour.js A modules/ext.guidedTour.lib.js A tests/ext.guidedTour.lib.tests.js 5 files changed, 607 insertions(+), 413 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/43103 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I604dcc7f41a1ece1fefc8f1ed0d5a78dc5946aa4 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/GuidedTour Gerrit-Branch: master Gerrit-Owner: Mattflaschen <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: Swalling <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
