Ema has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282976
Change subject: varnishmedia: ignore transaction without status code
......................................................................
varnishmedia: ignore transaction without status code
We have noticed instances of the following exception:
varnishmedia[87046]: File "/usr/local/bin/varnishmedia", line 45, in
process_transaction
varnishmedia[87046]: status_code = transaction['TxStatus']
varnishmedia[87046]: KeyError: 'TxStatus'
This patch makes sure we only process transactions with a status code.
Bug: T132430
Change-Id: I3db782353320c9600923a42f58b33011fb0a9229
---
M modules/varnish/files/varnishmedia
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/76/282976/1
diff --git a/modules/varnish/files/varnishmedia
b/modules/varnish/files/varnishmedia
index ff50133..e464993 100755
--- a/modules/varnish/files/varnishmedia
+++ b/modules/varnish/files/varnishmedia
@@ -42,7 +42,10 @@
def process_transaction(self, transaction):
"""Process a single completed transaction."""
- status_code = transaction['TxStatus']
+ status_code = transaction.get('TxStatus')
+ if status_code is None:
+ return
+
metric_keys = ['reqs.all', 'resps.' + status_code]
if 'RxHeader' in transaction:
--
To view, visit https://gerrit.wikimedia.org/r/282976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3db782353320c9600923a42f58b33011fb0a9229
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
