Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/283177

Change subject: QUnit fixup release 0.17.1
......................................................................

QUnit fixup release 0.17.1

Change-Id: I400063f35f32a9ffb3f4100da38398642a4a7c3b
---
M RELEASE-NOTES.md
M ValueView.php
M tests/lib/jquery/jquery.focusAt.tests.js
M tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
4 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/data-values/value-view 
refs/changes/77/283177/1

diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index c925fd9..261eae6 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,5 +1,8 @@
 # ValueView release notes
 
+## 0.17.1 (2016-04-13)
+* Fixed `jQuery.focusAt` and `jquery.valueview.ExpertExtender.Listrotator` 
QUnit tests.
+
 ## 0.17.0 (2016-04-12)
 * `GlobeCoordinateInput` and `TimeInput` do not use 
`jQuery.valueview.ExpertExtender.Toggler` any
   more.
diff --git a/ValueView.php b/ValueView.php
index fa99ba9..81ddddb 100644
--- a/ValueView.php
+++ b/ValueView.php
@@ -5,7 +5,7 @@
        return 1;
 }
 
-define( 'VALUEVIEW_VERSION', '0.17.0' );
+define( 'VALUEVIEW_VERSION', '0.17.1' );
 
 // Include the composer autoloader if it is present.
 if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
diff --git a/tests/lib/jquery/jquery.focusAt.tests.js 
b/tests/lib/jquery/jquery.focusAt.tests.js
index e998f8a..f159e69 100644
--- a/tests/lib/jquery/jquery.focusAt.tests.js
+++ b/tests/lib/jquery/jquery.focusAt.tests.js
@@ -101,6 +101,7 @@
                                'Can call focusAt on element not in DOM yet.'
                        );
                } catch ( e ) {
+                       assert.expect( 1 );
                        assert.ok(
                                e.name === 'NS_ERROR_FAILURE' && e.result === 
0x80004005,
                                'Unable to focus since browser requires element 
to be in the DOM.'
diff --git a/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js 
b/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
index 68711bd..aeed867 100644
--- a/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
+++ b/tests/src/ExpertExtender/ExpertExtender.Listrotator.tests.js
@@ -67,7 +67,7 @@
 
                listrotator.init( $extender );
                listrotator.draw();
-               listrotator.rotator.prev();
+               listrotator.rotator._setValue( 'fixed value' );
 
                setTimeout( function() {
                        sinon.assert.calledOnce( onValueChange );

-- 
To view, visit https://gerrit.wikimedia.org/r/283177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I400063f35f32a9ffb3f4100da38398642a4a7c3b
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to