Filippo Giunchedi has submitted this change and it was merged.

Change subject: logstash: transform nulls as zero for graphite alert
......................................................................


logstash: transform nulls as zero for graphite alert

Change-Id: Ic834a3a34d936d0f94369268a3f6eff0621f08e8
---
M modules/role/manifests/graphite/alerts.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Filippo Giunchedi: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/graphite/alerts.pp 
b/modules/role/manifests/graphite/alerts.pp
index e5e904d..351f512 100644
--- a/modules/role/manifests/graphite/alerts.pp
+++ b/modules/role/manifests/graphite/alerts.pp
@@ -38,7 +38,7 @@
     # https://logstash.wikimedia.org/#/dashboard/elasticsearch/memcached
     monitoring::graphite_threshold { 'mediawiki-memcached-threshold':
         description => 'MediaWiki memcached error rate',
-        metric      => 'logstash.rate.mediawiki.memcached.ERROR.sum',
+        metric      => 
'transformNull(logstash.rate.mediawiki.memcached.ERROR.sum, 0)',
         # Nominal error rate in production is <150/min
         warning     => 1000,
         critical    => 5000,

-- 
To view, visit https://gerrit.wikimedia.org/r/283461
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic834a3a34d936d0f94369268a3f6eff0621f08e8
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to