jenkins-bot has submitted this change and it was merged.
Change subject: Make static analysis happy by forcing to string
......................................................................
Make static analysis happy by forcing to string
We already know this is a string because of the is_string() check,
but that's not quite enough to make static analysis happy. Lets
just placate it...
Bug: T132625
Change-Id: I2290e2cd502f1f1b216bd062bcf312ba172cc909
---
M includes/Updater.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
DCausse: Looks good to me, approved
jenkins-bot: Verified
Objections:
Cindy-the-browser-test-bot: There's a problem with this change, please improve
diff --git a/includes/Updater.php b/includes/Updater.php
index 38d19cf..dcd4253 100644
--- a/includes/Updater.php
+++ b/includes/Updater.php
@@ -132,7 +132,7 @@
}
$content = $page->getContent();
if ( is_string( $content ) ) {
- $content = new TextContent( $content );
+ $content = new TextContent( (string) $content );
}
// If the event that the content is _still_ not usable,
we have to give up.
if ( !is_object( $content ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/283357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2290e2cd502f1f1b216bd062bcf312ba172cc909
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
