jenkins-bot has submitted this change and it was merged.
Change subject: Avoid DBPerformance log warnings in SpecialPreferences
......................................................................
Avoid DBPerformance log warnings in SpecialPreferences
Preference views do not need the master DB.
Change-Id: Id0c3fc6d453b6af0eca8450107da6d554c822347
---
M includes/specials/SpecialPreferences.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialPreferences.php
b/includes/specials/SpecialPreferences.php
index 7f257e6..2e7b4cd 100644
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -74,7 +74,11 @@
$this->addHelpLink( 'Help:Preferences' );
// Load the user from the master to reduce CAS errors on double
post (T95839)
- $user = $this->getUser()->getInstanceForUpdate() ?:
$this->getUser();
+ if ( $this->getRequest()->wasPosted() ) {
+ $user = $this->getUser()->getInstanceForUpdate() ?:
$this->getUser();
+ } else {
+ $user = $this->getUser();
+ }
$htmlForm = Preferences::getFormObject( $user,
$this->getContext() );
$htmlForm->setSubmitCallback( [ 'Preferences', 'tryUISubmit' ]
);
--
To view, visit https://gerrit.wikimedia.org/r/283586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0c3fc6d453b6af0eca8450107da6d554c822347
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
