Brian Wolff has uploaded a new change for review.
https://gerrit.wikimedia.org/r/283753
Change subject: Put a high max limit of 60,000 on Special:LinkSearch
......................................................................
Put a high max limit of 60,000 on Special:LinkSearch
LinkSearch uses inefficient paging. Previously there was no
max limit, then it was 10,000, but people on enwiki are complaining,
so put it up to something high, like 60,000, to fix the immediate
issue.
Special page should of course be changed to use efficient paging.
Bug: T130058
Change-Id: I0c4b1ad0138571bcf286ca88bceebf86b9a095f6
---
M includes/specials/SpecialLinkSearch.php
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/53/283753/1
diff --git a/includes/specials/SpecialLinkSearch.php
b/includes/specials/SpecialLinkSearch.php
index 2a7046e..1ecbee0 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -299,4 +299,14 @@
protected function getGroupName() {
return 'redirects';
}
+
+ /**
+ * enwiki complained about low limits on this special page
+ *
+ * @see T130058
+ * @todo FIXME This special page should not use LIMIT for paging
+ */
+ protected function getMaxResults() {
+ return max( parent::getMaxResults(), 60000 );
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/283753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c4b1ad0138571bcf286ca88bceebf86b9a095f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
