jenkins-bot has submitted this change and it was merged.
Change subject: Detect null-edit for a new topic summary
......................................................................
Detect null-edit for a new topic summary
null-edit detection is in place from one revision
to the next but the first version of a topic
summary was always seen as an edit worth
notify about.
Bug: T132531
Change-Id: Ic3979d7ccd18e73c27b00892157e295925538f5e
---
M includes/Block/TopicSummary.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Block/TopicSummary.php b/includes/Block/TopicSummary.php
index 88f5798..ef159cb 100644
--- a/includes/Block/TopicSummary.php
+++ b/includes/Block/TopicSummary.php
@@ -138,6 +138,10 @@
isset( $this->submitted['format'] ) ?
$this->submitted['format'] : 'wikitext',
'create-topic-summary'
);
+
+ if ( !trim( $this->submitted['summary'] ) ) {
+ $this->extraCommitMetadata['null-edit'] = true;
+ }
// Edit topic summary
} else {
if ( !$this->permissions->isAllowed(
$this->topicSummary, 'edit-topic-summary' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/283871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3979d7ccd18e73c27b00892157e295925538f5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
