jenkins-bot has submitted this change and it was merged.
Change subject: ISSUERID is alphanumeric due to SEPA
......................................................................
ISSUERID is alphanumeric due to SEPA
The format of this field has changed. I found the new values using a
GET_DIRECTORY call, and added a couple of new banks to the list.
Bug: T131904
Change-Id: I0124ae9efe598c81d75b750db9d46b0fb40377bf
---
M globalcollect_gateway/config/data_constraints.yaml
M globalcollect_gateway/config/payment_submethods.yaml
M globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html
M globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
4 files changed, 34 insertions(+), 28 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/globalcollect_gateway/config/data_constraints.yaml
b/globalcollect_gateway/config/data_constraints.yaml
index e435831..8af0555 100644
--- a/globalcollect_gateway/config/data_constraints.yaml
+++ b/globalcollect_gateway/config/data_constraints.yaml
@@ -148,10 +148,10 @@
user_ip:
type: alphanumeric
length: 32
-# ISSUERID: N4
+# ISSUERID: AN11
issuer_id:
- type: numeric
- length: 4
+ type: alphanumeric
+ length: 11
# LANGUAGECODE: AN2
language:
type: alphanumeric
diff --git a/globalcollect_gateway/config/payment_submethods.yaml
b/globalcollect_gateway/config/payment_submethods.yaml
index 8948ae6..fc27c05 100644
--- a/globalcollect_gateway/config/payment_submethods.yaml
+++ b/globalcollect_gateway/config/payment_submethods.yaml
@@ -246,15 +246,17 @@
keys:
- ISSUERID
issuerids:
- 771: 'SNS Regio Bank'
- 161: 'Van Lanschot Bankiers'
- 31: 'ABN AMRO'
- 761: 'ASN Bank'
- 21: Rabobank
- 511: 'Triodos Bank'
- 721: ING
- 751: 'SNS Bank'
- 801: Knab
+ ABNANL2A: ABN Amro
+ ASNBNL21: ASN Bank
+ FRBKNL2L: Friesland Bank
+ INGBNL2A: ING
+ KNABNL2H: Knab
+ RABONL2U: Rabobank
+ RBRBNL21: RegioBank
+ SNSBNL2A: SNS Bank
+ TRIONL2U: Triodos Bank
+ FVLBNL22: Van Lanschot Bankiers
+ BUNQNL2A: bunq
rtbt_enets:
paymentproductid: 810
label: eNETS
diff --git a/globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html
b/globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html
index f73d55e..492f29a 100644
--- a/globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html
+++ b/globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html
@@ -72,17 +72,19 @@
<select style="margin-top: 15px;" id="issuer_id" name="issuer_id"
value="@issuer_id">
<option value="">%donate_interface-rtbt-issuer_id%...</option>
<optgroup>
-
<option value="31">ABN AMRO</option>
-
<option value="721">ING</option>
-
<option value="21">Rabobank</option>
-
<option value="751">SNS Bank</option>
+
<option value="ABNANL2A">ABN Amro</option>
+
<option value="INGBNL2A">ING</option>
+
<option value="RABONL2U">Rabobank</option>
+
<option value="SNSBNL2A">SNS Bank</option>
</optgroup>
<optgroup label="%donate_interface-rtbt-issuer_id-longlist%">
-
<option value="761">ASN Bank</option>
+
<option value="ASNBNL21">ASN Bank</option>
+
<option value="FRBKNL2L">Friesland Bank</option>
<!-- <option value="801">Knab</option> -->
-
<option value="771">RegioBank</option>
-
<option value="511">Triodos Bank</option>
-
<option value="161">Van Lanschot Bankiers</option>
+
<option value="RBRBNL21">RegioBank</option>
+
<option value="TRIONL2U">Triodos Bank</option>
+
<option value="FVLBNL22">Van Lanschot Bankiers</option>
+
<option value="BUNQNL2A">bunq</option>
</optgroup>
</select>
diff --git a/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
b/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
index c735fab..b09265c 100644
--- a/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
+++ b/globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
@@ -72,17 +72,19 @@
<select style="margin-top: 15px;" id="issuer_id" name="issuer_id"
value="@issuer_id">
<option value="">%donate_interface-rtbt-issuer_id%...</option>
<optgroup>
-
<option value="31">ABN AMRO</option>
-
<option value="721">ING</option>
-
<option value="21">Rabobank</option>
-
<option value="751">SNS Bank</option>
+
<option value="ABNANL2A">ABN Amro</option>
+
<option value="INGBNL2A">ING</option>
+
<option value="RABONL2U">Rabobank</option>
+
<option value="SNSBNL2A">SNS Bank</option>
</optgroup>
<optgroup label="%donate_interface-rtbt-issuer_id-longlist%">
-
<option value="761">ASN Bank</option>
+
<option value="ASNBNL21">ASN Bank</option>
+
<option value="FRBKNL2L">Friesland Bank</option>
<!-- <option value="801">Knab</option> -->
-
<option value="771">RegioBank</option>
-
<option value="511">Triodos Bank</option>
-
<option value="161">Van Lanschot Bankiers</option>
+
<option value="RBRBNL21">RegioBank</option>
+
<option value="TRIONL2U">Triodos Bank</option>
+
<option value="FVLBNL22">Van Lanschot Bankiers</option>
+
<option value="BUNQNL2A">bunq</option>
</optgroup>
</select>
--
To view, visit https://gerrit.wikimedia.org/r/283276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0124ae9efe598c81d75b750db9d46b0fb40377bf
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
