jenkins-bot has submitted this change and it was merged.
Change subject: Add tooltips for 'mark as read' and 'more options'
......................................................................
Add tooltips for 'mark as read' and 'more options'
Bug: T130831
Change-Id: I1533d20019157c05f9354a60661512a33920c336
---
M Resources.php
M i18n/en.json
M i18n/qqq.json
M modules/ooui/mw.echo.ui.NotificationItemWidget.js
4 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Resources.php b/Resources.php
index feea1c2..df71cbc 100644
--- a/Resources.php
+++ b/Resources.php
@@ -133,6 +133,8 @@
"notification-timestamp-ago-years",
'echo-notification-markasread',
'echo-notification-markasunread',
+ 'echo-notification-markasread-tooltip',
+ 'echo-notification-more-options-tooltip',
'echo-notification-alert-text-only',
'echo-notification-message-text-only',
'echo-email-batch-bullet',
diff --git a/i18n/en.json b/i18n/en.json
index 258e31e..ae046ea 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -96,6 +96,8 @@
"echo-notification-popup-loginrequired": "Please log in to view your
notifications.",
"echo-notification-markasread": "Mark as read",
"echo-notification-markasunread": "Mark as unread",
+ "echo-notification-markasread-tooltip": "Mark as read",
+ "echo-notification-more-options-tooltip": "More options",
"notification-link-text-expand-all": "View all",
"notification-link-text-expand-alert-count": "View {{PLURAL:$1|$1
alert|$1 alerts}}",
"notification-link-text-expand-message-count": "View {{PLURAL:$1|$1
message|$1 messages}}",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ecfd82b..7c3cb37 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -87,6 +87,8 @@
"echo-notification-popup-loginrequired": "Message that displays when an
anonymous user attempts to view notifications in their popup after a session
expired.",
"echo-notification-markasread": "Label for the button to mark the
notification as read.",
"echo-notification-markasunread": "Label for the button to mark the
notification as unread.",
+ "echo-notification-markasread-tooltip": "Tooltip for the button to mark
the notification as read.",
+ "echo-notification-more-options-tooltip": "Tooltip for the button to
show the hidden secondary actions.",
"notification-link-text-expand-all": "Label for the button that expands
a bundled notification.\n{{Identical|View all}}",
"notification-link-text-expand-alert-count": "Label for the button that
expands a bundled alert notification.\n\nParameters:\n* $1 - The count of
messages that the bundle holds.\n{{Identical|View alert}}",
"notification-link-text-expand-message-count": "Label for the button
that expands a bundled message notification.\n\nParameters:\n* $1 - The count
of messages that the bundle holds.\n{{Identical|View message}}",
diff --git a/modules/ooui/mw.echo.ui.NotificationItemWidget.js
b/modules/ooui/mw.echo.ui.NotificationItemWidget.js
index 81552ba..26621cf 100644
--- a/modules/ooui/mw.echo.ui.NotificationItemWidget.js
+++ b/modules/ooui/mw.echo.ui.NotificationItemWidget.js
@@ -32,10 +32,11 @@
this.$actions = $( '<div>' )
.addClass(
'mw-echo-ui-notificationItemWidget-content-actions' );
- // Mark unread
+ // Mark as read
this.markAsReadButton = new OO.ui.ButtonWidget( {
icon: 'close',
framed: false,
+ title: mw.msg( 'echo-notification-markasread-tooltip' ),
classes: [
'mw-echo-ui-notificationItemWidget-markAsReadButton' ]
} );
@@ -76,6 +77,7 @@
icon: 'ellipsis',
$overlay: this.$overlay,
menuWidth: 200,
+ title: mw.msg( 'echo-notification-more-options-tooltip'
),
classes: [
'mw-echo-ui-notificationItemWidget-content-actions-menu' ]
} );
--
To view, visit https://gerrit.wikimedia.org/r/283746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1533d20019157c05f9354a60661512a33920c336
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
