jenkins-bot has submitted this change and it was merged.
Change subject: Fixed incorrect type label
......................................................................
Fixed incorrect type label
Change-Id: Ib6be96d3717bed43bd70589e1dc4b342ea3d5e0f
---
M includes/JCTabularContentView.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/JCTabularContentView.php
b/includes/JCTabularContentView.php
index ca6d840..10cfebb 100644
--- a/includes/JCTabularContentView.php
+++ b/includes/JCTabularContentView.php
@@ -56,7 +56,7 @@
$index = 0;
foreach ( $headers as $column ) {
list( $column, $columnAttrs ) = self::split(
$column );
- $type = $types && array_key_exists( $index,
$types ) ? $types[$index] : 'invalid';
+ $type = !empty( $types[$index] ) ?
$types[$index] : 'invalid';
$typeClass = $infoClass;
$typeClass['title'] = wfMessage(
'jsonconfig-type-name-' . $type )->plain();
$typeAbbr = wfMessage( 'jsonconfig-type-abbr-'
. $type )->plain();
--
To view, visit https://gerrit.wikimedia.org/r/284265
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6be96d3717bed43bd70589e1dc4b342ea3d5e0f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/JsonConfig
Gerrit-Branch: master
Gerrit-Owner: Yurik <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
