Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/284484
Change subject: Fix ExternalStoreDB IDEA errors
......................................................................
Fix ExternalStoreDB IDEA errors
Change-Id: I6200173fd1cba4bdf03b61659a48016107672fad
---
M includes/externalstore/ExternalStoreDB.php
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/284484/1
diff --git a/includes/externalstore/ExternalStoreDB.php
b/includes/externalstore/ExternalStoreDB.php
index a75ed27..b454577 100644
--- a/includes/externalstore/ExternalStoreDB.php
+++ b/includes/externalstore/ExternalStoreDB.php
@@ -33,6 +33,8 @@
* The provided URL is in the form of DB://cluster/id
* or DB://cluster/id/itemid for concatened storage.
*
+ * @param string $url
+ * @return string|bool False if missing
* @see ExternalStoreMedium::fetchFromURL()
*/
public function fetchFromURL( $url ) {
@@ -83,11 +85,8 @@
return $ret;
}
- /**
- * @see ExternalStoreMedium::store()
- */
- public function store( $cluster, $data ) {
- $dbw = $this->getMaster( $cluster );
+ public function store( $location, $data ) {
+ $dbw = $this->getMaster( $location );
$id = $dbw->nextSequenceValue( 'blob_blob_id_seq' );
$dbw->insert( $this->getTable( $dbw ),
[ 'blob_id' => $id, 'blob_text' => $data ],
@@ -97,7 +96,7 @@
throw new MWException( __METHOD__ . ': no insert ID' );
}
- return "DB://$cluster/$id";
+ return "DB://$location/$id";
}
/**
@@ -175,7 +174,7 @@
* @param string $cluster
* @param string $id
* @param string $itemID
- * @return mixed
+ * @return HistoryBlob|bool Returns false if missing
* @private
*/
function fetchBlob( $cluster, $id, $itemID ) {
--
To view, visit https://gerrit.wikimedia.org/r/284484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6200173fd1cba4bdf03b61659a48016107672fad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
