jenkins-bot has submitted this change and it was merged.
Change subject: Correction to test
......................................................................
Correction to test
The change in If4e0dfb6ee6674f0dace80a01850e2d0cbbdb47a
had a side effect of exposing a flaw in one of the BetaFeatures
tests. The default value of the NewHTMLCheckField was true before
but it was not rendering the checkbox as checked. Now this value is
honoured due to the call to HtmlFormField::getDefault which previously
was not called if the empty( $value->mParams['nodata'] ) was true.
Rather than change the HTML of the test, I've updated the setup
behaviour so that the checkbox is not checked initially.
Bug: T133163
Change-Id: Icb1e6ddc8f95da5e4b4de2916d292694c11ba731
---
M tests/NewCheckFieldTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/NewCheckFieldTest.php b/tests/NewCheckFieldTest.php
index 535ab77..edca590 100644
--- a/tests/NewCheckFieldTest.php
+++ b/tests/NewCheckFieldTest.php
@@ -30,7 +30,7 @@
'blahblahblah' => array(
'class' => 'NewHTMLCheckField',
'label-message' =>
'betafeatures-test-check-field',
- 'default' => true,
+ 'default' => false,
)
) );
$form->setTitle( Title::newMainPage() );
--
To view, visit https://gerrit.wikimedia.org/r/284485
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb1e6ddc8f95da5e4b4de2916d292694c11ba731
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
